Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: update; add readline.vim #66829

Merged
merged 1 commit into from Aug 19, 2019
Merged

vimPlugins: update; add readline.vim #66829

merged 1 commit into from Aug 19, 2019

Conversation

parisni
Copy link
Contributor

@parisni parisni commented Aug 18, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

sorry for the poor testing: just copied others way to add vim plugins and hope that's actually the way.

@teto
Copy link
Member

teto commented Aug 19, 2019

how does it compare with https://github.com/tpope/vim-rsi ?

@parisni
Copy link
Contributor Author

parisni commented Aug 19, 2019

improvements are:

  1. this only apply to command-mode (does not break the vim philosophy for insert/normal mode)
  2. this better implement the readline standard (treats new word as newline does, allows upper/lowercase, make ctrl-w works as expected ...)

@teto teto merged commit cc0fbe5 into NixOS:master Aug 19, 2019
@parisni parisni mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parisni @teto @Janik-Haag