@GrahamcOfBorg build tclreadline

/nix/store/ffl5ag647lkglhgd2yjdisajn5zzrr78-stdenv-darwin/setup: line 105: patchelf: command not found

right. disabled patchelf on darwin

@jtojnar good to go?

One thing I do not like is patching the ELF files. Surely, there must be a better way.

Is the binary patching a blocker? I'd write a patch for upstream, but I'm not much knowledgeable about autotools

Ping

I guess I could do something like

if [ relevant contents of .libs are also present in $out/lib ]; then
  patchelf --set-rpath $(patchelf --print-rpath $executable | sed -s @$builddir/.libs:@@) $executable
else
  echo "Some libraries were not installed correctly"
  exit 1
fi

Would that be better?

@jtojnar what about it?

Sorry, missed your replies above. Yes that would be nicer.

I tried looking into the autotools build but was not able to determine where the rpath comes from. The only rpath reference in the generated Makefile is

libtclreadline.la: $(libtclreadline_la_OBJECTS) $(libtclreadline_la_DEPENDENCIES) $(EXTRA_libtclreadline_la_DEPENDENCIES) 
	$(AM_V_CCLD)$(libtclreadline_la_LINK) -rpath $(libdir) $(libtclreadline_la_OBJECTS) $(libtclreadline_la_LIBADD) $(LIBS)

and that should be $out/lib.

I marked this as stale due to inactivity. → More info

Result of nixpkgs-review pr 66830 run on x86_64-linux 1

Result of nixpkgs-review pr 66830 run on x86_64-darwin 1

@jtojnar here we go, better late than never :)

I implemented what I suggested here #66830 (comment)

Result of nixpkgs-review pr 66830 run on x86_64-linux 1

Result of nixpkgs-review pr 66830 run on x86_64-darwin 1