Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.uri: 2.2.0 -> 3.0.0 #67008

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.06.1-uri/versions.

meta.description for ocamlPackages.uri is: '"RFC3986 URI parsing library for OCaml"'.

meta.homepage for ocamlPackages.uri is: '"https://github.com/mirage/ocaml-uri"

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
libbap
python27Packages.bap
python37Packages.bap
stog

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/cywic24n5b0l93dmn67vk94y0f70y8kf-ocaml4.06.1-uri-3.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A ocamlPackages.uri https://github.com/r-ryantm/nixpkgs/archive/485c88a3112ccc97a5355f896935d859d04f1ac3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/cywic24n5b0l93dmn67vk94y0f70y8kf-ocaml4.06.1-uri-3.0.0
ls -la /nix/store/cywic24n5b0l93dmn67vk94y0f70y8kf-ocaml4.06.1-uri-3.0.0/bin

cc @vbgl for testing.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/ocaml4.06.1-uri/versions
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries (stog)

Sorry, something went wrong.

@mmahut mmahut merged commit dd2034d into NixOS:master Aug 20, 2019
@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2019

This broke ocamlPackages.cohttp

@mmahut
Copy link
Member

mmahut commented Aug 21, 2019

@vbgl thank you, looking at it, it fails with:

File "cohttp/src/dune", line 13, characters 29-37:
13 |  (libraries re stringext uri uri.sexp fieldslib sexplib0 bytes base64))
                                  ^^^^^^^^
Error: Library "uri.sexp" not found.

Looks like the latest release is using a different library as per mirage/ocaml-cohttp@0895fba. Could we maybe update ocamlPackages.cohttp?

@vbgl vbgl mentioned this pull request Aug 21, 2019
10 tasks
@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2019

Thanks for the suggestion; here is a PR: #67218

@r-ryantm r-ryantm deleted the auto-update/ocaml4.06.1-uri branch August 24, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants