Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.systemd: remove duplicate copypasta #66825

Merged
merged 1 commit into from Aug 18, 2019
Merged

nixosTests.systemd: remove duplicate copypasta #66825

merged 1 commit into from Aug 18, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 18, 2019

It seems the regression test for #35268 sneaked in twice.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar

@flokli
nixosTests.systemd: remove duplicate copypasta
ffef314 
It seems the regression test for NixOS#35268 sneaked in twice.
@flokli flokli requested a review from abbradar August 18, 2019 11:17
@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg test systemd

1 similar comment
@flokli
Copy link
Contributor Author

flokli commented Aug 18, 2019

@GrahamcOfBorg test systemd

@flokli
Copy link
Contributor Author

flokli commented Aug 18, 2019

There seems to be some generic flakyness in that test, but it shouldn't be related to this PR.

@flokli
Copy link
Contributor Author

flokli commented Aug 18, 2019

@GrahamcOfBorg test systemd

@flokli flokli merged commit 368be91 into NixOS:master Aug 18, 2019
@flokli flokli deleted the nixos-systemd-test-dup branch August 18, 2019 15:54
@flokli flokli mentioned this pull request Aug 19, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @mmahut