Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kronometer: name -> pname, version #66935

Merged
merged 1 commit into from Aug 22, 2019
Merged

kronometer: name -> pname, version #66935

merged 1 commit into from Aug 22, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Minor cleanup - should go into staging with the other kde changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace
worldofpeace reviewed Aug 20, 2019
View reviewed changes
pkgs/tools/misc/kronometer/default.nix
@@ -22,6 +19,6 @@ mkDerivation rec {
license = licenses.gpl2;
maintainers = with maintainers; [ peterhoeg ];
};
nativeBuildInputs = [ extra-cmake-modules kdoctools wrapGAppsHook ];
nativeBuildInputs = [ extra-cmake-modules kdoctools ];
propagatedBuildInputs = [ kconfig kcrash kinit ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs propagation?

@worldofpeace
Copy link
Contributor

should go into staging with the other kde changes.

I can see how that works organizationally, but it doesn't appear to change anything in staging.
Does it need to be built in staging to check for regressions? And even then, master gets merged into staging so we'll see it newly failing.

@peterhoeg
Copy link
Member Author

but it doesn't appear to change anything in staging

No, but it will need to be rebuilt when staging hits master due to a lot of kde changes currently in staging. So we might as well just merge this as part of that and only build it once.

@worldofpeace
Copy link
Contributor

Sounds reasonable then.

@worldofpeace worldofpeace merged commit 818087d into NixOS:staging Aug 22, 2019
@peterhoeg peterhoeg deleted the f/krono branch August 23, 2019 01:29
@peterhoeg peterhoeg restored the f/krono branch August 23, 2019 01:50
@peterhoeg peterhoeg deleted the f/krono branch September 13, 2019 09:51
@peterhoeg peterhoeg restored the f/krono branch September 13, 2019 11:03
@peterhoeg peterhoeg deleted the f/krono branch September 24, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @worldofpeace