Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-video-effects: 0.4.3 → 0.5.0 #66934

Merged
merged 2 commits into from Aug 19, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 19, 2019

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 19, 2019

Huh, from how they substitute the .pc file in meson datarootdir isn't relative to ${prefix} anymore

--- ./result/share/pkgconfig/gnome-video-effects.pc	1969-12-31 19:00:01.000000000 -0500
+++ /nix/store/27ml1s87l109aircbf47aigjcqsjd346-gnome-video-effects-0.5.0/share/pkgconfig/gnome-video-effects.pc	1969-12-31 19:00:01.000000000 -0500
@@ -1,7 +1,7 @@
-prefix = /nix/store/rxg02n90vc3y4nqjl296lkmrpamjik4q-gnome-video-effects-0.4.3
-datarootdir = ${prefix}/share
+prefix = /nix/store/27ml1s87l109aircbf47aigjcqsjd346-gnome-video-effects-0.5.0
+datarootdir = /nix/store/27ml1s87l109aircbf47aigjcqsjd346-gnome-video-effects-0.5.0/share/gnome-video-effects
 effectsdir = ${datarootdir}/gnome-video-effects
 
 Name: gnome-video-effects
 Description: A collection of GStreamer effects to be used in different GNOME Modules
-Version: 0.4.3
+Version: 0.5.0

and it looks like effectsdir will be a non-existent path?

@ofborg ofborg bot requested a review from worldofpeace August 19, 2019 16:56
@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 19, 2019

Hmm, you are right. Cheese relies on XDG_DATA_DIRS instead of the .pc file so that’s why the effects show up in there.

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 19, 2019

Before I managed to rebase the upstream MR so that the patch is applicable, it got merged 🤷‍♂️ So I added it in-tree 😦

@worldofpeace
Copy link
Contributor

Before I managed to rebase the upstream MR so that the patch is applicable, it got merged man_shrugging So I added it in-tree frowning

🤣 Wish some other MR's would get merged that fast. It's a pretty small patch so I guess it's fine.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@worldofpeace worldofpeace merged commit 80f4d61 into NixOS:master Aug 19, 2019
@jtojnar jtojnar deleted the gnome-video-effects-0.5.0 branch August 19, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants