Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.mox3: disabling tests #66930

Merged
merged 1 commit into from Aug 19, 2019
Merged

pythonPackages.mox3: disabling tests #66930

merged 1 commit into from Aug 19, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 19, 2019

Motivation for this change

Fixing https://hydra.nixos.org/build/98975821

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut requested a review from FRidh as a code owner August 19, 2019 14:40
@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

@GrahamcOfBorg build pythonPackages.mox3 python3Packages.mox3

Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I see hydra actually running tests very helpful to spot breakages.

The test requirements don't look too weird - could we probably just add them to checkInputs and keep running tests?

@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

The test requirements don't look too weird - could we probably just add them to checkInputs and keep running tests?

The problem is the test dependencies are not packaged in nixpkgs, therefore the test is trying to download them from pypi. Sadly this package doesn't have a maintainer and I don't want to put in the effort to package these all just to fix this one test.

@FRidh
Copy link
Member

FRidh commented Aug 19, 2019

Fixing test dependencies is indeed the preferred solution, however, as you're not the maintainer I can understand you don't want to add those expressions. Here users of the package (including reverse dependencies) may want to take a role NixOS/ofborg#387.

@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

@FRidh that's a good suggestion, but in this case this package is a dependency of none.

@FRidh FRidh merged commit 5646ada into NixOS:master Aug 19, 2019
@FRidh
Copy link
Member

FRidh commented Aug 19, 2019

Perfect, then let's not spend any time on it. Whoever chooses to use this package can take that responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants