Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pdfkit: 0.5.0 -> 0.6.1 #66928

Merged
merged 1 commit into from Aug 19, 2019
Merged

python3Packages.pdfkit: 0.5.0 -> 0.6.1 #66928

merged 1 commit into from Aug 19, 2019

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Update to the last version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MrMebelMan MrMebelMan requested a review from FRidh as a code owner August 19, 2019 14:36
@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@GrahamcOfBorg build pythonPackages.pdfkit python3Packages.pdfkit

jonringer
jonringer approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (1 suggestion)
leaf package

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66928
2 package were build:
python27Packages.pdfkit python37Packages.pdfkit

pkgs/development/python-modules/pdfkit/default.nix Outdated Show resolved Hide resolved
@FRidh FRidh merged commit 93f61c0 into NixOS:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrMebelMan @mmahut @jonringer @FRidh