Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amarok: 2.9.0-20180618 -> 2.9.0-20190731 #66931

Merged
merged 1 commit into from Aug 26, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Getting closer to a proper qt5 release.

Let's send it to staging due to the large number of kde changes there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@peterhoeg peterhoeg merged commit e200fd6 into NixOS:staging Aug 26, 2019
@peterhoeg peterhoeg deleted the u/amarok branch August 26, 2019 06:35
@peterhoeg peterhoeg restored the u/amarok branch August 26, 2019 23:41
@peterhoeg peterhoeg deleted the u/amarok branch September 13, 2019 09:52
@peterhoeg peterhoeg restored the u/amarok branch September 13, 2019 11:03
@peterhoeg peterhoeg deleted the u/amarok branch September 24, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant