New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua: fix cross-compilation; fixes #66742 #66883
Conversation
@@ -40,14 +40,17 @@ self = stdenv.mkDerivation rec { | |||
"PLAT=macosx" | |||
] else [ | |||
"PLAT=linux" | |||
]) | |||
]) ++ (if stdenv.buildPlatform != stdenv.hostPlatform then [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the if there ? if platfroms are equal then it won't matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's cleaner that way. Because if platforms are equal, we don't even need these args, we'll let the build system sort it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teto Additionally, this shouldn't cause a rebuild for people who are not cross-compiling!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not that familiar with cross compilation. Would like the opinon of @7c6f434c too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
The makefile isn't able to find the toolchain when cross-compiling. I helped it a little bit by adding the parameters explicitly.
9987bad
to
68847ae
Compare
Force-pushed a fix for a mass-rebuild of Lua packages! Accidentally left a space there... |
Motivation for this change
Tried to cross-compile Lua. Failed. Fiddled with the build system a bit and fixed it. Now contributing 馃樅 See #66742 for details.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
Wasn't able to find a maintainer for lua interpreter, sorry!