Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calibre: fix missing app icon and name when running under Wayland #66885

Closed
wants to merge 1 commit into from
Closed

calibre: fix missing app icon and name when running under Wayland #66885

wants to merge 1 commit into from

Conversation

lightbulbjim
Copy link
Contributor

@lightbulbjim lightbulbjim commented Aug 19, 2019 •
edited

Motivation for this change

Fixes the problem where the app icon would not show under Gnome/Wayland.

See https://honk.sigxcpu.org/con/GTK__and_the_application_id.html for context. In this case the app_id is calibre-gui.

Tested on Gnome/Wayland with the QT backend forced to Wayland, ie QT_QPA_PLATFORM=wayland calibre. If QT_QPA_PLATFORM is unset (or is set to xcb) it uses XWayland.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar @pSub @AndersonTorres

@lightbulbjim
calibre: rename .desktop file to match app_id
8a4dee9 
Fixes the problem where the app icon would not show under
Gnome/Wayland.
@lightbulbjim lightbulbjim changed the title calibre: rename .desktop file to match app_id calibre: fix missing app icon and name when running under Wayland Aug 29, 2019
@lightbulbjim
Copy link
Contributor Author

Found more things to fix. Will close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

@domenkozar domenkozar Awaiting requested review from domenkozar

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lightbulbjim