Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: 4.0.0 -> 4.1.0 #66775

Merged
merged 1 commit into from Sep 9, 2019
Merged

qemu: 4.0.0 -> 4.1.0 #66775

merged 1 commit into from Sep 9, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 17, 2019 •
edited

Motivation for this change

Update qemu to version 4.1.0
Changelog - https://wiki.qemu.org/ChangeLog/4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 17, 2019

@GrahamcOfBorg build qemu

@ofborg ofborg bot requested a review from edolstra August 17, 2019 18:29
@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

@GrahamcOfBorg test virtualbox

mmahut
mmahut approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut mentioned this pull request Aug 17, 2019
Closed
1 task
ivan
ivan approved these changes Sep 1, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested my VMs in virt-manager. Ordinary NixOS, Ubuntu, and Windows 10 VMs worked fine. My VFIO Windows 10 VM is also fine.

@ivan
Copy link
Member

ivan commented Sep 9, 2019

@edolstra do you want to review this, or can someone merge?

@edolstra edolstra merged commit 404caba into NixOS:master Sep 9, 2019
@Izorkin Izorkin deleted the qemu branch September 9, 2019 16:16
@wedens
Copy link

wedens commented Sep 20, 2019 •
edited

I'm not sure if it's worth a separate issue, so I'll just mention it here.

Note that you'll get error: unsupported configuration: host doesn't support hyperv 'vpindex' feature error if you have vpindex enabled in libvirt vm. This is due to some incompatibility with libvirt <4.6 and qemu>4.0. Upgrading to libvirt >4.6 (nixpkgs contains 4.4) or downgrading qemu to 4.0 should solve the problem.

@Izorkin
Copy link
Contributor Author

Izorkin commented Sep 20, 2019

With libvrit 4.6- 4.7 OS loading freezes- #66584 (comment)
No ideas how to fix it. I delete this script on my server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

@mmahut mmahut mmahut approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Izorkin @mmahut @ivan @wedens @edolstra