Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: 2.22.0 -> 2.23.0 #66773

Merged
merged 1 commit into from Aug 21, 2019
Merged

git: 2.22.0 -> 2.23.0 #66773

merged 1 commit into from Aug 21, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 17, 2019 •
edited

Motivation for this change

Update git to version 2.23.0
Changelog - https://lkml.org/lkml/2019/8/16/877

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 17, 2019

@GrahamcOfBorg build git
@GrahamcOfBorg test gitolite

@ofborg ofborg bot requested review from peti, the-kenny and wmertens August 17, 2019 18:16
@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

This should probably go to staging as a mass rebuild, please.

@wmertens wmertens changed the base branch from master to staging August 18, 2019 03:13
@wmertens wmertens changed the base branch from staging to master August 18, 2019 03:14
@wmertens
Copy link
Contributor

@Izorkin I tried changing the base but it picked up changes in 54 other files ;) LGTM, can you rebase on staging?

@FRidh FRidh added this to the 19.09 milestone Aug 18, 2019
@ttuegel ttuegel removed their request for review August 18, 2019 17:37
@peti peti merged commit 59d3b6e into NixOS:staging Aug 21, 2019
@Izorkin Izorkin deleted the git branch August 21, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@the-kenny the-kenny Awaiting requested review from the-kenny

@wmertens wmertens Awaiting requested review from wmertens

@alyssais alyssais Awaiting requested review from alyssais

@FRidh FRidh Awaiting requested review from FRidh

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Izorkin @mmahut @wmertens @peti @FRidh