Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass-otp: 1.1.1 -> 1.2.0 #66776

Merged
merged 1 commit into from Aug 18, 2019
Merged

pass-otp: 1.1.1 -> 1.2.0 #66776

merged 1 commit into from Aug 18, 2019

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Aug 17, 2019 •
edited

Had to specify BASHCOMPDIR in $out to keep things pure.

Motivation for this change

pass-otp has been outdated since november 2018 apparently.

Things done

I bumped this because the build failed on my machine, a mac. It still fails so I haven't been able to test the changes. The previous version worked fine on another mac so I think the build failure is specific to my machine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

EDIT: Managed to build it on another mac. And it generated an otp just fine.
P.s.: Should I add myself as a maintainer? If I'm using this anyway I don't mind keeping it up to date.

@ofborg ofborg bot requested a review from jwiegley August 17, 2019 18:32
@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

@GrahamcOfBorg build pass-otp

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@toonn feel free to add yourself as a maintainer.

@toonn
pass-otp: 1.1.1 -> 1.2.0
5a035ec 
Had to specify `BASHCOMPDIR` in `$out` to keep things pure.
@mmahut mmahut merged commit 44ba72b into NixOS:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley jwiegley approved these changes

@teto teto teto approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toonn @mmahut @jwiegley @teto