khal: build and install man page #66962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| install -D misc/__khal $out/share/zsh/site-functions/__khal | ||
|
|
||
| # man page | ||
| make -C doc man |
There was a problem hiding this comment.
Makefile doesn't support install for this?
There was a problem hiding this comment.
doesn't seem like it https://github.com/pimutils/khal/blob/master/doc/Makefile
|
While at it maybe you could install https://github.com/pimutils/khal/blob/master/misc/khal.desktop else I will do it in a follow up PR |
|
On Mon, 19 Aug 2019 22:07:52 -0700, Matthieu Coudron ***@***.***> wrote:
While at it maybe you could install https://github.com/pimutils/khal/blob/master/misc/khal.desktop else I will do it in a follow up PR
I started, the following addition to postInstall should do the trick:
```
# desktop
install -Dm755 misc/khal.desktop -t $out/share/applications
```
This doesn't work as-is however, since the current khal release doesn't
have the `.desktop` file.
Looks like someone we know was behind the PR adding it! ;)
Accordingly I may let you tackle this. I'll give it a go..
Maybe just fetchpatch the commit (in addition to snippet above),
drop the patch when bumping khal?
…
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#66962 (comment) part: text/html
|
|
let's wait for the next release then |
|
Oops, I went ahead and added it 😇. Works here! \o/ |
|
Thanks. Works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Man page is useful to have!
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @gebner