Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gvfs: set GIO_EXTRA_MODULES #66956

Merged
merged 8 commits into from
Aug 19, 2019
Merged

nixos/gvfs: set GIO_EXTRA_MODULES #66956

merged 8 commits into from
Aug 19, 2019
+67 −61

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I don't want all the modules setting GIO_EXTRA_MODULES independently.

This makes LXQT and Mate use the gvfs module which is something that should have been done anyway.

Things done

Built a GNOME3 VM.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 19, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 19, 2019
@worldofpeace
nixos/gvfs: move out of GNOME

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 1EF0B522349E532F
Learn about vigilant mode
67ad8a7
@worldofpeace
nixos/gvfs: add package option

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 1EF0B522349E532F
Learn about vigilant mode
eb127d2
@worldofpeace
nixos/gvfs: set GIO_EXTRA_MODULES

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4bb6625
@worldofpeace
nixos/gnome3: don't set GIO_EXTRA_MODULES
5b09814
@worldofpeace
nixos/pantheon: don't set GIO_EXTRA_MODULES
a686dc0
@worldofpeace
nixos/mate: don't set GiO_EXTRA_MODULES
45eac05
@worldofpeace
nixos/xfce: use gvfs module
5c5791c
@worldofpeace
nixos/lxqt: use gvfs module
ffe7999
@worldofpeace
Copy link
Contributor Author

Move gvfs to services.gvfs.

@worldofpeace worldofpeace merged commit 4b90f54 into NixOS:master Aug 19, 2019
@worldofpeace worldofpeace deleted the cleanup-gvfs-envars branch August 19, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@romildo romildo

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @romildo