Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gvfs: set GIO_EXTRA_MODULES #66956

Merged
merged 8 commits into from Aug 19, 2019
Merged

nixos/gvfs: set GIO_EXTRA_MODULES #66956

merged 8 commits into from Aug 19, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I don't want all the modules setting GIO_EXTRA_MODULES independently.

This makes LXQT and Mate use the gvfs module which is something that should have been done anyway.

Things done

Built a GNOME3 VM.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor Author

Move gvfs to services.gvfs.

@worldofpeace worldofpeace merged commit 4b90f54 into NixOS:master Aug 19, 2019
@worldofpeace worldofpeace deleted the cleanup-gvfs-envars branch August 19, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@romildo romildo romildo approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @romildo