Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wkhtmltopdf: use qt5's own mkDerivation #66847

Merged
merged 1 commit into from Aug 18, 2019
Merged

wkhtmltopdf: use qt5's own mkDerivation #66847

merged 1 commit into from Aug 18, 2019

Conversation

ivanbrennan
Copy link
Member

Motivation for this change

Currently, wkhtmltopdf fails at runtime as it cannot find the offscreen plugin:

wkhtmltopdf http://example.com example.pdf
qt.qpa.plugin: Could not find the Qt platform plugin "offscreen" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted
Things done

Referencing #65399, used the Qt mkDerivation wrapper.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace
worldofpeace approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks.

@worldofpeace worldofpeace merged commit 2a7542c into NixOS:master Aug 18, 2019
@ivanbrennan ivanbrennan deleted the wkhtmltopdf branch August 19, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanbrennan @worldofpeace