Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: fix malformed meta.maintainers #66842

Merged
merged 1 commit into from Aug 19, 2019

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Aug 18, 2019

Motivation for this change

These packages stood out while processing packages.json.gz,
where the maintainers field of some packages wasn't the expected list of sets,
but a nested list, or a string.

Notify maintainers

cc @sterfield @1000101

@tilpner
Copy link
Member Author

tilpner commented Aug 18, 2019

@worldofpeace I agree, it's now using maintainers = gnome3.maintainers;

@worldofpeace
Copy link
Contributor

Sounds good @tilpner, no further actions needed?

@tilpner
Copy link
Member Author

tilpner commented Aug 18, 2019

We could give @sterfield another day to speak up, I'm not sure they want to be maintainer. But otherwise no, merge whenever. :)

@1000101
Copy link
Member

1000101 commented Aug 19, 2019

@tilpner Just out of curiosity - how precisely did you find this? Many thanks for cleaning up my mess!!!

@sterfield
Copy link
Contributor

Hey all,

I have created this package quite some time ago, but unfortunately, I don't have a lot of time to spend on NixOS (plus I'm afraid to say that my knowledge on NixOs stayed quite low).

But IIRC, this package is fairly simple, so I could still try to maintain it from time to time.

Tell me if you want to remove me from the list or keep me. Either way, I'm fine.

Thanks,

These packages stood out while processing packages.json.gz,
where the maintainer field of some packages wasn't a list of sets,
but a nested list, or a string.
@tilpner
Copy link
Member Author

tilpner commented Aug 19, 2019

@1000101 I was processing packages.json to sort maintainers by the count of their packages, and there were meta.maintainers lists that contained lists or contained just plain strings, instead of being the expected lists of attrsets.

As you know, Nix handles identifiers starting with digits differently than those starting with letters. To prevent this error in the future, one option would be to rename your attribute. It's fine to keep it like this, you just have double-check every time that you put an attrset instead of a string into the maintainers field.

@sterfield In that case, I'll keep you as maintainer, because you will eventually receive notifications when changes are proposed to sickrage. If you are not any longer a user of nixpkgs and sickrage in particular, feel free to remove yourself as a maintainer.

@worldofpeace worldofpeace merged commit 7667ae1 into NixOS:master Aug 19, 2019
@1000101 1000101 mentioned this pull request May 11, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants