nixos/timesyncd: run migration even if stateVersion is unset #66982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migration is needed on most systems that previously had pre-19.09 installed. We have any easy check for it in ‘[ -L /var/lib/systemd/timesync ]’ that avoid duplicate migrations. We should run it for unset stateVersion configurations too. Fixes NixOS#64922
infinisil
reviewed
Aug 19, 2019
| @@ -40,7 +40,7 @@ with lib; | |||
| users.users.systemd-timesync.uid = config.ids.uids.systemd-timesync; | |||
| users.groups.systemd-timesync.gid = config.ids.gids.systemd-timesync; | |||
|
|
|||
| system.activationScripts.systemd-timesyncd-migration = mkIf (versionOlder config.system.stateVersion "19.09") '' | |||
| system.activationScripts.systemd-timesyncd-migration = mkIf ((versionOlder config.system.stateVersion "19.09") || !(config.system ? stateVersion)) '' | |||
There was a problem hiding this comment.
This can't work, stateVersion is always set because it has a default, and even if it wouldn't be always set config.system ? stateVersion would still always be true.
|
I think the real solution might be to change the condition to something like This way people don't need to set |
|
Yeah, that would be nice, but I'm not sure if it would work either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration is needed on most systems that previously had pre-19.09
installed. We have any easy check for it in ‘[ -L
/var/lib/systemd/timesync ]’ that avoid duplicate migrations. We
should run it for unset stateVersion configurations too.
Fixes #64922
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @