python3Packages.pydot_ng: moving pytest and mock to checkInputs #66925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling not working test, given this is an archived project by upstream.
|
@GrahamcOfBorg build pythonPackages.pydot_ng python3Packages.pydot_ng |
jonringer
reviewed
Aug 19, 2019
There was a problem hiding this comment.
Personally, I would do this:
top-level/python-package.nix
pydot_ng = callPackage ../development/python-modules/pydot_ng { graphviz = pkgs.graphviz; };
python-modules/pydot_ng/default.nix (puts graphviz on PATH for checkPhase)
{ stdenv, buildPythonPackage, fetchPypi, isPy27
, graphviz
, mock
, pyparsing
, pytest
, unittest2
}:
buildPythonPackage rec {
pname = "pydot_ng";
version = "2.0.0";
src = fetchPypi {
inherit pname version;
sha256 = "8c8073b97aa7030c28118961e2c6c92f046e4cb57aeba7df87146f7baa6530c5";
};
propagatedBuildInputs = [ graphviz pyparsing ];
checkInputs = [
graphviz
mock
pytest
] ++ stdenv.lib.optionals isPy27 [ unittest2];
checkPhase = ''
py.test
'';
meta = with stdenv.lib; {
homepage = "https://pypi.python.org/pypi/pydot-ng";
description = "Python 3-compatible update of pydot, a Python interface to Graphviz's Dot";
license = licenses.mit;
maintainers = [ maintainers.bcdarwin ];
};
}
|
@jonringer I was just trying to fix the broken build. Would you like to take over the package? @bcdarwin has been unresponsive for some time. |
|
@mmahut I'll bump it, but I don't really have any interest in the package itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixing https://hydra.nixos.org/build/98961910
Disabling not working tests, given this is an archived project
by upstream, rest is passing.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @bcdarwin