Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.uuidm: 0.9.6 -> 0.9.7 #67015

Merged
merged 1 commit into from Aug 20, 2019
Merged

ocamlPackages.uuidm: 0.9.6 -> 0.9.7 #67015

merged 1 commit into from Aug 20, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/uuidm/versions.

meta.description for ocamlPackages.uuidm is: '"An OCaml module implementing 128 bits universally unique identifiers version 3, 5 (name based with MD5, SHA-1 hashing) and 4 (random based) according to RFC 4122"'.

meta.homepage for ocamlPackages.uuidm is: '"https://erratique.ch/software/uuidm"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

23 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
5 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
libbap
pyre
python27Packages.bap
python37Packages.bap
stog
trv

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4i67gfjnqmngg2l08jcxaif6jyw5qg36-uuidm-0.9.7 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A ocamlPackages.uuidm https://github.com/r-ryantm/nixpkgs/archive/f80422fc01e6f6dc1586189ee090a4dba93b0b3b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4i67gfjnqmngg2l08jcxaif6jyw5qg36-uuidm-0.9.7
ls -la /nix/store/4i67gfjnqmngg2l08jcxaif6jyw5qg36-uuidm-0.9.7/bin

cc @maurer for testing.

@r-ryantm
ocamlPackages.uuidm: 0.9.6 -> 0.9.7
f80422f 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/uuidm/versions
mmahut
mmahut approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries (stog)

@mmahut mmahut merged commit 13df6fd into NixOS:master Aug 20, 2019
@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2019

@mmahut Please mark uuidm as broken with OCaml 4.01 (if said breakage is intended).

@mmahut
Copy link
Member

mmahut commented Aug 21, 2019

@maurer do you mind checking what the breakage is? I did not find anything upstream.

@vbgl
Copy link
Contributor

vbgl commented Aug 21, 2019

File "src/uuidm.mli", line 34, characters 9-14:
Error: Unbound type constructor bytes

@r-ryantm r-ryantm deleted the auto-update/uuidm branch August 24, 2019 21:16
@maurer
Copy link
Member

maurer commented Aug 25, 2019

https://github.com/ocaml/opam-repository/blob/master/packages/uuidm/uuidm.0.9.7/opam#L11

tl;dr uuidm 0.9.7 is an OCaml 4.03+ package, so it failing on 4.01 is unsurprising.

There are only two packages in nixpkgs currently using uuidm: BAP, and alcotest.
alcotest currently requires 4.03+, and latest BAP (which we haven't upgraded to yet) is 4.04+

My reccomendation is to disable uuidm for <4.03 with an assert (similar to

nixpkgs/pkgs/development/ocaml-modules/ocaml-cairo/default.nix

Line 7 in 257c652

if stdenv.lib.versionAtLeast ocaml.version "4.06"

) and for the OCaml maintainers to investigate removing 4.01 in general, since most of the OCaml ecosystem has moved beyond it.

If you want to keep uuidm support for OCaml 4.01, consider a construction like:

nixpkgs/pkgs/top-level/ocaml-packages.nix

Line 33 in 17a2721

async_find =

while keeping the old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @vbgl @mmahut @maurer