Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eksctl: 0.3.1 -> 0.4.1 #67012

Merged
merged 1 commit into from Aug 23, 2019
Merged

eksctl: 0.3.1 -> 0.4.1 #67012

merged 1 commit into from Aug 23, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Aug 20, 2019 •
edited

Motivation for this change

Update eksctl to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from kalbasit August 20, 2019 03:29
@xrelkd xrelkd changed the title eksctl: 0.3.1 -> 0.4.0 eksctl: 0.3.1 -> 0.4.1 Aug 20, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 20, 2019

@GrahamcOfBorg build eksctl

1 similar comment
@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@GrahamcOfBorg build eksctl

@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 22, 2019

@mmahut Thanks for calling @GrahamcOfBorg to build eksctl on x86_64-darwin.
Could we merge this PR?

@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

Looks good, thank you @xrelkd for the update.

@mmahut mmahut merged commit 9a7a18e into NixOS:master Aug 23, 2019
@xrelkd xrelkd deleted the update/eksctl branch August 23, 2019 06:44
@xrelkd
Copy link
Contributor Author

xrelkd commented Aug 23, 2019

@mmahut Thank you for merging this PR!
However, eksctl has been updated again. Could you review #67328?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @mmahut