New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starship: 0.10.1 -> 0.12.0 #66947
starship: 0.10.1 -> 0.12.0 #66947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM (trivial bump)
executable seems to work
leaf package
[4 built, 37 copied (595.2 MiB), 161.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66947
1 package were build:
starship
Alas, more test failures when building this on macOS 🤦♀ |
Looks like this is already being tracked at starship/starship#199 |
It seems the test failures boil down to This is being tracked in starship/starship#199. In the meantime, we could just disable the check phase on the package. |
I would first try |
That's weird. I'm pretty sure I have sandboxing (it's been enabled by default for a while, right?). ➜ nix run nixpkgs.nix-info -c nix-info -m
I'm the one who set
Is there something wrong on my side? |
There's |
Maybe sandboxing on NixOS allows access to |
Looking at https://github.com/NixOS/nix/blob/6924bdf2bf8f50f2e6ec5d490571594450aba13a/src/libstore/sandbox-defaults.sb, the macOS sandbox allows for reading the metadata of |
The test using If you want to list all the directory while in the sandbox you can build starship on the |
If I change
|
Listing the contents of |
I updated the PR. |
|
OK I excluded that one too. |
This now builds on macOS
|
There's already another release. |
I would just bump, rebase, and push. You already went through quite a gauntlet of reviews :) |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM
binary seems to work
leaf package
[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66947
1 package were build:
starship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails to build on macOS, It needs the Security
framework now.
builder for '/nix/store/nmfi9qzqg6acrkfkcmvfwjcb6kxcggw7-starship-0.12.0-vendor.drv' failed with exit code 1; last 10 log lines:
Referenced from: /nix/store/2bbgqwpafjv7pzfa0027wkqp9k56s60a-cargo-1.36.0/bin/.cargo-wrapped
Reason: no suitable image found. Did find:
/System/Library/Frameworks/Security.framework/Versions/A/Security: file system sandbox blocked stat()
/System/Library/Frameworks/Security.framework/Versions/A/Security: file system sandbox blocked stat()
Traceback (most recent call last):
File "/nix/store/84c6nr9wqk77wlasa0nyxjnp2nj5bxd4-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 42, in <module>
main()
File "/nix/store/84c6nr9wqk77wlasa0nyxjnp2nj5bxd4-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 17, in main
assert list(data.keys()) == ["source"]
AssertionError
cannot build derivation '/nix/store/vsr8ha88ggagv5f7y34pvl1afsw1vnrl-starship-0.12.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/a654z46clgvl76msiyh009pn41w8g4fm-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 132 copied (1645.9 MiB), 373.2 MiB DL]
error: build of '/nix/store/a654z46clgvl76msiyh009pn41w8g4fm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/66947
1 package failed to build:
starship
}; | ||
|
||
buildInputs = [ openssl ] ++ stdenv.lib.optionals stdenv.isDarwin [ libiconv darwin.apple_sdk.frameworks.Security ]; | ||
nativeBuildInputs = [ pkgconfig ]; | ||
|
||
cargoSha256 = "126y8q19qr37wrj6x4hqh0v7nqr9yfrycwqfgdlaw6i33gb0qam9"; | ||
cargoSha256 = "0qlgng5j6l1r9j5vn3wnq25qr6f4nh10x90awiqyzz8jypb0ng2c"; | ||
checkPhase = "cargo test -- --skip directory::home_directory --skip directory::directory_in_root"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add a comment above this phase linking to starship/starship#204 as that's the issue that tracks the reason for skipping these tests. This way we'll have an easy reference for when this overridden phase can be deleted.
Looking at the derivation, it already includes Security, so I guess the problem is actually that it's referencing the system Security framework rather than the Nix one. I'm not sure what's going on there. |
The failure is actually when trying to execute the wrapped |
Ok I've figured out what's going on. This review was done on a different machine, whose |
darwin sounds fun... :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on darwin.
[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66947
1 package were build:
starship
The binary executes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging entirely based on the good word of @lilyball and @jonringer. Thanks all!
Motivation for this change
Fix the parallel tests on darwin issue and other stuff. @lilyball
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)nix path-info -S /nix/store/lax8qmvfkdj634ism8jafw4djvxjsxv6-starship-0.10.1
/nix/store/lax8qmvfkdj634ism8jafw4djvxjsxv6-starship-0.10.1 35764408
nix path-info -S /nix/store/sb4iaff8xksw7x37b4llbiw0938wvh45-starship-0.11.0
/nix/store/sb4iaff8xksw7x37b4llbiw0938wvh45-starship-0.11.0 35769720