Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] transifex-client: fixing build #66789

Merged
merged 2 commits into from Aug 17, 2019
Merged

[19.03] transifex-client: fixing build #66789

merged 2 commits into from Aug 17, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 17, 2019 •
edited

Motivation for this change

Cherry picking changes from master to fix https://hydra.nixos.org/build/98275180

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @etu

etu and others added 2 commits August 17, 2019 22:06
@mmahut mmahut requested a review from etu August 17, 2019 20:08
@mmahut mmahut changed the title transifex-client: fixing build [19.03] transifex-client: fixing build Aug 17, 2019
@etu etu merged commit 67135fb into NixOS:release-19.03 Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @etu