Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] Security backports for gollum, jekyll, and html-proofer #66818

Merged
merged 6 commits into from Aug 18, 2019
Merged

[19.03] Security backports for gollum, jekyll, and html-proofer #66818

merged 6 commits into from Aug 18, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 18, 2019 •
edited

Motivation for this change

Dependency updates for CVE-2019-5477 in Nokogiri (fixed in 1.10.4+).
These packages might not be vulnerable to CVE-2019-5477 (I haven't checked it), but better safe than sorry and these updates will also avoid warnings from bundler-audit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@primeos
gollum: Update the dependencies (security, CVE-2019-5477)
0f7e68e 
(cherry picked from commit 2ae080f)
@primeos
jekyll: 3.8.5 -> 3.8.6 (security)
4cc42a3 
There was a minor security issue (no CVE) [0]:
> Security Fixes
> - Theme gems: ensure directories aren't symlinks (NixOS#7424)

More details: jekyll/jekyll#7419

[0]: https://github.com/jekyll/jekyll/releases

(cherry picked from commit 1834b4f)
@primeos
jekyll: Update the dependencies (security, CVE-2019-5477)
7492f64 
(cherry picked from commit 42a777d)
@primeos
html-proofer: 3.10.2 -> 3.11.0
70a8048 
(cherry picked from commit 7124645)
@primeos
html-proofer: 3.11.0 -> 3.11.1
c350a7b 
(cherry picked from commit a6ffab4)
@primeos
html-proofer: Update the dependencies (security, CVE-2019-5477)
9eabb49 
(cherry picked from commit b770ded)
@primeos primeos self-assigned this Aug 18, 2019
@primeos primeos merged commit 641a1ff into NixOS:release-19.03 Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos