Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5ad409e8974e
Choose a base ref
...
head repository: m-labs/nmigen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c934fc66e90a
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 20, 2019

  1. test.test_examples: Convert pathlib-specific class to string.

    subprocess.check_call iterates over its arguments to check for spaces
    and tabs, and on Windows, the pathlib-specific WindowsPath is not
    iterable.
    cr1901 authored and whitequark committed Aug 20, 2019
    Copy the full SHA
    c934fc6 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 nmigen/test/test_examples.py
2 changes: 1 addition & 1 deletion nmigen/test/test_examples.py
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@
def example_test(name):
path = (Path(__file__).parent / ".." / ".." / "examples" / name).resolve()
def test_function(self):
subprocess.check_call([sys.executable, path, "generate"], stdout=subprocess.DEVNULL)
subprocess.check_call([sys.executable, str(path), "generate"], stdout=subprocess.DEVNULL)
return test_function