Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase: 4.1.0 -> 4.3.1 #67018

Merged
merged 2 commits into from Aug 22, 2019
Merged

keybase: 4.1.0 -> 4.3.1 #67018

merged 2 commits into from Aug 22, 2019

Conversation

jonafato
Copy link
Contributor

Motivation for this change

Keybase has new releases. keybase and keybase-gui are being updated together here to prevent breakage from version mismatches (i.e. the gui does not work).

Changelogs are available at https://github.com/keybase/client/releases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rvolosatovs @puffnfresh @np @carlsverre

@jonafato jonafato changed the title Keybase 4.3.1 keybase: 4.1.0 -> 4.3.1 Aug 20, 2019
rvolosatovs
rvolosatovs approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything builds and works fine for me!

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@GrahamcOfBorg build keybase keybase-gui

angristan
angristan approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything builds and run for me locally. 👍

@mmahut mmahut merged commit 6f4ab87 into NixOS:master Aug 22, 2019
@jonafato jonafato deleted the keybase-4.3.1 branch August 22, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angristan angristan angristan approved these changes

@rvolosatovs rvolosatovs rvolosatovs approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonafato @mmahut @angristan @rvolosatovs