Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pydot_ng: fix build #66966

Merged
merged 1 commit into from Aug 23, 2019
Merged

pythonPackages.pydot_ng: fix build #66966

merged 1 commit into from Aug 23, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 19, 2019 •
edited

Motivation for this change

was helping out @mmahut and decided to take over the package from #66925

closes #66925

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bcdarwin

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66966
2 package were build:
python27Packages.pydot_ng python37Packages.pydot_ng

@jonringer jonringer requested a review from FRidh as a code owner August 19, 2019 19:29
@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@GrahamcOfBorg build pythonPackages.pydot_ng python3Packages.pydot_ng

@mmahut
Copy link
Member

mmahut commented Aug 23, 2019

Thank you @jonringer, you rocks.

@mmahut mmahut merged commit 611fbf7 into NixOS:master Aug 23, 2019
@jonringer jonringer deleted the bump-pydot-ng branch August 23, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mmahut