Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-plugins: 1.1.9 -> 1.1.10 #66963

Merged
merged 2 commits into from Oct 22, 2019
Merged

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/lsp-plugins/versions.

meta.description for lsp-plugins is: '"Collection of open-source audio plugins"'.

meta.homepage for lsp-plugins is: '"https://lsp-plug.in"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
lsp-plugins
pulseeffects

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/jzqc18v1z0z0p8cahc1chm0ns1xiqapr-lsp-plugins-1.1.10 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A lsp-plugins https://github.com/r-ryantm/nixpkgs/archive/4cb5a2c2b21c2deba0a0a6684c47c9499f4def25.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/jzqc18v1z0z0p8cahc1chm0ns1xiqapr-lsp-plugins-1.1.10
ls -la /nix/store/jzqc18v1z0z0p8cahc1chm0ns1xiqapr-lsp-plugins-1.1.10/bin

cc @magnetophon for testing.

Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@GrahamcOfBorg build lsp-plugins

@mmahut mmahut self-requested a review August 19, 2019 20:57
@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Fails on aarch64.

In file included from /build/source/include/dsp/dsp.h:11:0,
                 from aarch64.cpp:8:
/build/source/include/dsp/arch/aarch64/features.h:73:45: error: 'HWCAP_ASIMDFHM' was not declared in this scope
     #define HWCAP_AARCH64_ASIMDFHM          HWCAP_ASIMDFHM
                                             ^
/build/source/include/common/types.h:109:41: note: in definition of macro 'IF_ARCH_AARCH64'
     #define IF_ARCH_AARCH64(...)        __VA_ARGS__
                                         ^~~~~~~~~~~
aarch64.cpp:106:11: note: in expansion of macro 'HWCAP_AARCH64_ASIMDFHM'
         { HWCAP_AARCH64_ASIMDFHM, "ASIMDFHM" },
           ^~~~~~~~~~~~~~~~~~~~~~```

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

ping @magnetophon do you mind taking a look?

@magnetophon
Copy link
Member

@mmahut I got an answer upstream:
lsp-plugins/lsp-plugins#56
Could you test?

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@mmahut I got an answer upstream:
sadko4u/lsp-plugins#56
Could you test?

This should be already included in glibc I think. Hmm.

Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/lsp-plugins/versions
@marsam
Copy link
Contributor

marsam commented Oct 22, 2019

@GrahamcOfBorg build lsp-plugins

@ofborg ofborg bot requested a review from magnetophon October 22, 2019 08:38
Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a aarch64, so I don't think I can be of much use there, sorry!

@marsam marsam merged commit ea8686e into NixOS:master Oct 22, 2019
@marsam
Copy link
Contributor

marsam commented Oct 22, 2019

yeah, I've disabled it for aarch64. Thanks for your patience.

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 22, 2019
lsp-plugins: 1.1.9 -> 1.1.10
(cherry picked from commit ea8686e)
@r-ryantm r-ryantm deleted the auto-update/lsp-plugins branch November 1, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants