Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: 9.1.0 -> 9.2.0 #66836

Merged
merged 1 commit into from Aug 19, 2019
Merged

gcc: 9.1.0 -> 9.2.0 #66836

merged 1 commit into from Aug 19, 2019

Conversation

xbreak
Copy link
Contributor

@xbreak xbreak commented Aug 18, 2019

Motivation for this change

gcc 9.2.0 is a bug-fix release, c.f. https://gcc.gnu.org/gcc-9/changes.html for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested compilation of internal packages that use gcc9Stdenv
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Synthetica9, @dtzWill

@xbreak
gcc: 9.1.0 -> 9.2.0
549cbc0 
gcc 9.2.0 is a bug-fix release.
vcunat
vcunat approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me.

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg build gcc

@vcunat
Copy link
Member

vcunat commented Aug 18, 2019

(this PR doesn't update the default gcc)

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

Right, thank you.

@GrahamcOfBorg build gcc9

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Builds for me fine, working fine as well.

@mmahut mmahut merged commit 1316d81 into NixOS:master Aug 19, 2019
@xbreak xbreak deleted the update/gcc-9.2 branch August 19, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xbreak @mmahut @vcunat