Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qownnotes: 19.7.3 -> 19.8.6, use qt's mkDerivation #66987

Merged
merged 1 commit into from Aug 20, 2019
Merged

qownnotes: 19.7.3 -> 19.8.6, use qt's mkDerivation #66987

merged 1 commit into from Aug 20, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Aug 19, 2019

Motivation for this change

Update, fix (cc #65399).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill O:)

jonringer
jonringer approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary seems to work
leaf package

[3 built, 5 copied (6.5 MiB), 1.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66987
1 package were build:
qownnotes

worldofpeace
worldofpeace approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, executes on my machine without runtime error. Confirmed it's wrapped.

@worldofpeace
Copy link
Contributor

Can you squash your commits @dtzWill?

@dtzWill dtzWill force-pushed the update/qownnotes-qt-mkderiv branch from 8fc7b3d to 9a2c241 Compare August 20, 2019 05:52
@dtzWill
Copy link
Member Author

dtzWill commented Aug 20, 2019 via email

@worldofpeace worldofpeace merged commit c0b62a7 into NixOS:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @worldofpeace @jonringer