Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: 1.0.0.59 -> 1.0.0.61 #66916

Merged
merged 1 commit into from Aug 25, 2019
Merged

steam: 1.0.0.59 -> 1.0.0.61 #66916

merged 1 commit into from Aug 25, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Aug 19, 2019 •
edited

Motivation for this change

The udev rules are updated upstream so it doesn't need a patch anymore to make the controllers work

Close #49367
Close #50901

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jagajaga

This was referenced Aug 19, 2019
Closed
Closed
@ofborg ofborg bot requested a review from jagajaga August 19, 2019 13:30
@jD91mZM2
Copy link
Member

I have tested this with

nix-review pr 66916

and ran steam. Appears to work :)

vcunat
vcunat approved these changes Aug 24, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine in my case, including a few games.

Nitpick: the task-tray icon stopped showing for me. I don't update steam often (via nix*), so it might be unrelated to this bump.

@globin globin merged commit 4819131 into NixOS:master Aug 25, 2019
@nyanloutre nyanloutre deleted the steam_update_1_0_0_61 branch August 25, 2019 21:30
@cdepillabout cdepillabout mentioned this pull request Oct 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@jD91mZM2 jD91mZM2 jD91mZM2 approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @jD91mZM2 @vcunat @globin