Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: add bs-platform #66914

Closed
wants to merge 1 commit into from
Closed

nodePackages: add bs-platform #66914

wants to merge 1 commit into from
+2,599 −1,884

Conversation

Huddo121
Copy link

Motivation for this change

bs-platform contains some CLI tools for getting started writing ReasonML. I've made this change by blindly following the instructions here. I've been able to test the executables by running nix-build -A nodePackages.bs-platform and then trying them out in the result symlink, but I haven't been able to run something like nix-shell -I mynixpkgsdir -p nodePackages.bs-platform, shouldn't that work?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ No owners listed in CODEOWNERS 🤷‍♂

Sorry, something went wrong.

@Huddo121
Copy link
Author

Well, running nix-shell with a file like the following seems to work so maybe I am being a bit of a numpty with my nix-shell command from above.

let
  pkgs = import (/Users/mhudson/Development/nixpkgs) {};
in
with pkgs;
mkShell {
  buildInputs = [ nodejs yarn nodePackages.bs-platform ];
}

@marsam
Copy link
Contributor

marsam commented Aug 30, 2019

just curious, does this work? IIRC bucklescript uses postInstall script to build their executables, which requires ninja and a specific ocaml version.

@Huddo121
Copy link
Author

Huddo121 commented Sep 1, 2019

@marsam Argh, good spot, you're right, I just tried this out on my NixOS machine and it crapped out. I must have already had Ninja laying around when I first tried to nixify this. I've settled on using the JS ecosystem tools from within a nix-shell for now, I'll close this PR, as it seems like it might be tricky to deal with their scripts/install.js script and there's an alternative approach.

@Huddo121 Huddo121 closed this Sep 1, 2019
@turboMaCk
Copy link
Member

related #73570

@turboMaCk turboMaCk mentioned this pull request Nov 17, 2019
Merged
10 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Huddo121 @marsam @turboMaCk @Janik-Haag