Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
base: 77012fc1438f
Choose a base ref
...
head repository: m-labs/nmigen
compare: 13316053e331
Choose a head ref
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on Aug 19, 2019

  1. build.plat, hdl.ir: coordinate missing domain creation. 

    Platform.prepare() was completely broken after addition of local
clock domains, and only really worked before by a series of
accidents because there was a circular dependency between creation
of missing domains, fragment preparation, and insertion of pin
subfragments.

This commit untangles the dependency by adding a separate public
method Fragment.create_missing_domains(), used in build.plat.

It also makes DomainCollector consider both used and defined domains,
such that it will work on fragments before domain propagation, since
create_missing_domains() can be called by user code before prepare().

The fragment driving missing clock domain is not flattened anymore,
because flattening does not work well combined with local domains.
    whitequark committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    1331605 View commit details
    Browse the repository at this point in the history