nixos: zsh: setopt prompt_sp to workaround a zsh bug #66992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See NixOS#38535, properly fixing the prompt seems complicated, and this seems to work in all the ttys I checked. Suggested by @Mic92.
8 tasks
|
Should also fix #30121 I think. |
|
This should be eligible for backporting as well. |
md-magenta
added a commit
to neic/dotfiles
that referenced
this pull request
Apr 6, 2023
A change was introduced in zsh [1] changing the default of PROMPT_SP [2]. It did not however change the walter prompt [3] that nix formerly used as default and nix-darwin still uses as default [4]. In nix it was reported in [5] and fixed in [6]. In nix-darwin a fix have been made in [7], but it is not merged. A later change in nix [8] gives a hint that you should use `prompt off` if overwriting your prompt in `.zshrc`. [1] zsh-users/zsh@43e55a9 [2] https://zsh.sourceforge.io/Doc/Release/Options.html#Prompting [3] https://github.com/zsh-users/zsh/blob/master/Functions/Prompts/prompt_walters_setup#L23 [4] https://github.com/LnL7/nix-darwin/blob/master/modules/programs/zsh/default.nix#:~:text=programs.zsh.promptInit [5] NixOS/nixpkgs#30121 [6] NixOS/nixpkgs#66992 [7] LnL7/nix-darwin#488 [8] NixOS/nixpkgs@2eaf575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
See #38535. I took the fix by @Mic92 and tested it in all the ttys and ptys I ever use. It seems to work.
Closes #38535.
git lognixos: zsh: setopt prompt_sp to workaround a zsh bug
See nixos/zsh: do not set ZSH prompt to the 'walters' style #38535, properly fixing the prompt seems complicated, and this seems
to work in all the ttys I checked.
Suggested by @Mic92.
nix-instantiateenvironmentnix-env -qaPdiffs/cc @dtzWill