Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nftables: enable all features in kernel #66841

Merged
merged 1 commit into from Oct 16, 2019
Merged

nftables: enable all features in kernel #66841

merged 1 commit into from Oct 16, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 18, 2019 •
edited

Motivation for this change

Enable all nftables features in kernel 5.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This change is Reviewable

@Izorkin
Copy link
Contributor Author

Izorkin commented Aug 18, 2019

@GrahamcOfBorg build linux_5_2

@Izorkin
Copy link
Contributor Author

Izorkin commented Sep 10, 2019

@GrahamcOfBorg build linux_5_2

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 14, 2019

@GrahamcOfBorg build linux_5_2
@GrahamcOfBorg build linux_5_3

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 14, 2019

@GrahamcOfBorg build linux_5_2
@GrahamcOfBorg build linux_5_3

@Izorkin Izorkin changed the title nftables: enable all features in kernel 5.2 nftables: enable all features in kernel Oct 14, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 14, 2019

@GrahamcOfBorg build linux_4_4
@GrahamcOfBorg build linux_5_3

Mic92
Mic92 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me. All options added here are also enabled in archlinux.

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 15, 2019

Need this option - SCTP load balancing support?
Networking support > Networking options > Network packet filtering framework (Netfilter) > IP virtual server support on > SCTP load balancing support

@Mic92 Mic92 merged commit 334921a into NixOS:master Oct 16, 2019
@Mic92
Copy link
Member

Mic92 commented Oct 16, 2019

@Izorkin Probably not SCTP is rarely in use, especially in areas where NixOS is used.

@Izorkin Izorkin deleted the kernel-nftables branch October 16, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @Mic92 @lheckemann