Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docui: 1.0.3 -> 2.0.0 #66813

Merged
merged 2 commits into from Aug 18, 2019
Merged

docui: 1.0.3 -> 2.0.0 #66813

merged 2 commits into from Aug 18, 2019

Conversation

eugenezastrogin
Copy link
Member

@eugenezastrogin eugenezastrogin commented Aug 18, 2019 •
edited

Motivation for this change

https://github.com/skanehira/docui/releases/tag/2.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eugenezastrogin eugenezastrogin changed the title Update/docui 2.0.0 docui: 1.0.3 -> 2.0.0 Aug 18, 2019
@ofborg ofborg bot requested a review from kalbasit August 18, 2019 07:47
@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg build docui

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

@GrahamcOfBorg build docui

mmahut
mmahut approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@mmahut mmahut merged commit 388e154 into NixOS:master Aug 18, 2019
@eugenezastrogin eugenezastrogin mentioned this pull request Aug 20, 2019
Open
@eugenezastrogin eugenezastrogin deleted the update/docui-2.0.0 branch August 21, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eugenezastrogin @mmahut