Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulseview: use mkDerivation #66869

Merged
merged 1 commit into from Aug 19, 2019
Merged

pulseview: use mkDerivation #66869

merged 1 commit into from Aug 19, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

stdenv.mkDerivation -> the Qt specific version of mkDerivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor

@ofborg ofborg bot requested a review from bjornfor August 19, 2019 06:05
@bjornfor bjornfor merged commit 374e0ad into NixOS:master Aug 19, 2019
@bjornfor bjornfor mentioned this pull request Aug 19, 2019
Closed
10 tasks
@peterhoeg peterhoeg deleted the f/pulseview branch August 19, 2019 14:14
@peterhoeg peterhoeg restored the f/pulseview branch August 19, 2019 15:21
@peterhoeg peterhoeg deleted the f/pulseview branch August 19, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @bjornfor