Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apmplanner2: fix build against qt 5.12 #66871

Merged
merged 1 commit into from Aug 19, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Couple of things:

  1. Apply a patch to make it compile with Qt 5.12
  2. stdenv.mkDerivation -> mkDerivation
  3. name -> pname, version

I don't actually use this application - it was part of a cleanup for a new KDE version that touched Qt which prompted this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @wucke13

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

@GrahamcOfBorg build apmplanner2

@mmahut mmahut merged commit 22aa7ea into NixOS:master Aug 19, 2019
@peterhoeg peterhoeg deleted the f/apmplanner branch August 19, 2019 09:48
@peterhoeg peterhoeg restored the f/apmplanner branch August 19, 2019 12:01
@wucke13
Copy link
Contributor

wucke13 commented Aug 19, 2019

Seems to work fine, thanks for the contribution!

@peterhoeg peterhoeg deleted the f/apmplanner branch August 19, 2019 14:50
@peterhoeg peterhoeg restored the f/apmplanner branch August 19, 2019 15:21
@peterhoeg peterhoeg deleted the f/apmplanner branch August 19, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants