Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jenkinsapi: fixing tests #66937

Closed
wants to merge 1 commit into from
Closed

pythonPackages.jenkinsapi: fixing tests #66937

wants to merge 1 commit into from

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 19, 2019 •
edited

Motivation for this change

Fixing https://hydra.nixos.org/build/98959263

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @drets

@mmahut mmahut requested a review from FRidh as a code owner August 19, 2019 15:28
@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

@GrahamcOfBorg build pythonPackages.jenkinsapi python3Packages.jenkinsapi

@mmahut
Copy link
Member Author

mmahut commented Aug 26, 2019

@GrahamcOfBorg build pythonPackages.jenkinsapi python3Packages.jenkinsapi

@drets
Copy link
Member

drets commented Aug 26, 2019

Thanks for pinging :)

@mmahut do you want to become a maintainer?

I am not really interested in maintaining this package anymore.

@mmahut
Copy link
Member Author

mmahut commented Aug 27, 2019

@drets I am not, not using Jenkins, just fixing the broken builds ahead of 19.09.

The build now hangs at running build_ext, do you mind having a look? :)

@drets
Copy link
Member

drets commented Aug 27, 2019 •
edited

@mmahut I spent some time on it. Sorry, can't spend more, a lot of work at work.

But now I am curious what the fix is. :)

BTW you can add pykerberos to checkInputs and then no need to remove any tests.

@drets drets mentioned this pull request Sep 2, 2019
Closed
@mmahut mmahut closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @drets