Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.boltztrap2: moving cmake to nativeBuildInputs #66939

Closed
wants to merge 1 commit into from
Closed

python3Packages.boltztrap2: moving cmake to nativeBuildInputs #66939

wants to merge 1 commit into from

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 19, 2019

Motivation for this change

Fixing https://hydra.nixos.org/build/98969449

Moving cmake to nativeBuildInputs, cleaning up test dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @costrouc

@mmahut mmahut requested a review from costrouc August 19, 2019 15:38
@mmahut mmahut requested a review from FRidh as a code owner August 19, 2019 15:38
@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

@GrahamcOfBorg build python3Packages.boltztrap2

@costrouc
Copy link
Member

Why were the tests removed?

@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

Why were the tests removed?

They were not enabled in the first place.

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/boltztrap2/default.nix#L31

@jonringer
Copy link
Contributor

@mmahut I was one step ahead of you, sorry. Also did a version bump #66035

@mmahut mmahut closed this Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc Awaiting requested review from costrouc

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @costrouc @jonringer