Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btanks: patching away wrong lua library #66852

Merged
merged 1 commit into from Aug 19, 2019
Merged

btanks: patching away wrong lua library #66852

merged 1 commit into from Aug 19, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 18, 2019 •
edited

Motivation for this change

Fixing long failing build https://hydra.nixos.org/build/98444634

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
Copy link
Member

teto commented Aug 19, 2019

tested with nix-review

@teto
Copy link
Member

teto commented Aug 19, 2019

is this supposed to work on darwin ? if not restrict the platform.

@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

is this supposed to work on darwin ? if not restrict the platform.

Hard to say, did not build this before ofborg. Going to disable as I have no way to test it.

@teto
Copy link
Member

teto commented Aug 19, 2019

seems like there were builds for macos https://sourceforge.net/projects/btanks/files/ so maybe revert the platform change and someone on mac can unbreak it later.

@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

seems like there were builds for macos https://sourceforge.net/projects/btanks/files/ so maybe revert the platform change and someone on mac can unbreak it later.

I think it is better the way around, we can have it build for linux only and if someone would like to maintain it for darwin, they can add the support (very little probability).

@teto teto merged commit 147b7ab into NixOS:master Aug 19, 2019
@teto
Copy link
Member

teto commented Aug 19, 2019

what if it used to work before ? I wonder if the mac failure was due to the PR or nixpkgs. My bad for not checking so I apologize for mac users that will see an error because of this.

@mmahut
Copy link
Member Author

mmahut commented Aug 19, 2019

@teto looks like it did broke back in January with the scons update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@gloaming gloaming gloaming left review comments

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @teto @gloaming