Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

franz: 5.0.0-beta.19 -> 5.1.0 #62586

Merged
merged 1 commit into from Jun 3, 2019
Merged

franz: 5.0.0-beta.19 -> 5.1.0 #62586

merged 1 commit into from Jun 3, 2019

Conversation

davidtwco
Copy link
Member

Motivation for this change

There's a more recent version of Franz available. Newest version is required to keep Slack services working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jun 3, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 739f74d into NixOS:master Jun 3, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 3, 2019

@davidtwco thanks!

@davidtwco davidtwco deleted the franz-5.1.0 branch June 3, 2019 09:46
davidtwco added a commit to davidtwco/veritas that referenced this pull request Jun 3, 2019
@davidtwco
Remove franz override (NixOS/nixpkgs#62586)
168003a
@davidtwco davidtwco mentioned this pull request Jul 22, 2019
Merged
10 tasks
@davidtwco davidtwco mentioned this pull request Oct 23, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidtwco @Ma27 @Janik-Haag