Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia: strip out gfortran refs #62619

Merged
merged 1 commit into from Jun 4, 2019

Conversation

matthewbauer
Copy link
Member

Fixes #62588

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rbvermaa
Copy link
Member

rbvermaa commented Jun 4, 2019

I can't remember if I added that, or copied that over from the older expressions, though. Have you tested these changes (I don't think there are any tests for anything julia related) if basic julia still works, if so, I'm fine with the changes.

@matthewbauer
Copy link
Member Author

Built and found no regressions

@matthewbauer matthewbauer merged commit d60310f into NixOS:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using dockerTools for Julia 1.1 includes gfortran in image
2 participants