Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localtime: set geoclue config #62623

Merged
merged 1 commit into from
Jun 5, 2019
Merged

localtime: set geoclue config #62623

merged 1 commit into from
Jun 5, 2019
+7 −1

Conversation

michaelpj
Copy link
Contributor

The geoclue module now lets us set application config. This should make
it more robust in environments that don't provide a geoclue agent.

Fixes #44725.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@michaelpj
localtime: set geoclue config

Verified

This commit was signed with the committer’s verified signature.
sxzz Kevin Deng 三咲智子
GPG key ID: 69992F2250DFD93E
Verified
Learn about vigilant mode
d3a4a5b 
The geoclue module now lets us set application config. This should make
it more robust in environments that don't provide a geoclue agent.

Fixes NixOS#44725.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 3, 2019
@worldofpeace worldofpeace merged commit cc5ec44 into NixOS:master Jun 5, 2019
@chreekat
Copy link
Contributor

chreekat commented Jun 5, 2019

Neat!

The issue mentions both localtime and redshift, but this PR only looks to be fixing localtime. Does something more need to happen for redshift to work? Or does this also fix that?

@michaelpj
Copy link
Contributor Author

See #62624

@chreekat
Copy link
Contributor

chreekat commented Jun 5, 2019

Nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redshift, localtime can't talk to geoclue
3 participants
@michaelpj @chreekat @worldofpeace