Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re2: 20140304 -> 20190401 #62335

Merged
merged 2 commits into from
Jun 9, 2019
Merged

re2: 20140304 -> 20190401 #62335

merged 2 commits into from
Jun 9, 2019
+17 −10

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 1, 2019

Motivation for this change

I was surprised this had been left untouched for so long, so am bumping it - in the process enabling both the checks and install-checks.

I haven't tested the full nox-review rebuild on linux yet, because it involves building chromium three times, which I don't really have the appetite for. I have tested building most reverse-dependencies though, and all on macos (there being fewer).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

risicle added 2 commits May 31, 2019 22:25
@risicle
re2: 20140304 -> 20190401
9ecdc72
@risicle
re2: enable check, installCheck

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6a1ade5
@risicle risicle mentioned this pull request Jun 7, 2019
Closed
10 tasks
@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

@GrahamcOfBorg build re2 dnsdist
(I can't test darwin otherwise)

Chromium build logs show that the re2 input isn't used, and we have a comment there

# "re2" # fails with linker errors

so I think it's safe in that respect. Perhaps now we would be able to use our re2 in chromium, but perhaps there's not too much motivation with the library being small (relatively to chromium). /cc chromium maintainers: @bendlas, @ivan.

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019 •
edited
Loading

@risicle: do you want yourself in meta.maintainers? There's noone ATM, and you see it's been practically untouched for years. EDIT: anyway, I won't delay merging, as we can add you later.

@vcunat vcunat merged commit 6a1ade5 into NixOS:master Jun 9, 2019
vcunat added a commit that referenced this pull request Jun 9, 2019
@vcunat
Merge #62335: re2: 20140304 -> 20190401
8de4579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @vcunat