Ibus: binding fixes #62392
Merged
Ibus: binding fixes #62392
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a Python 2 library that we install to Python 3 prefix. Even if it were used by anything it would not work.
ofborg
bot
added
10.rebuild-darwin: 0
lukateras
approved these changes
Jun 1, 2019
|
It does not seem to be enough to fix #61978 |
In testing that, have you also added |
|
Not sure, will double check once I get home. |
$ echo 'with import <nixpkgs> { };
mkShell {
buildInputs = [
gobject-introspection
ibus
(python3.withPackages (p: [p.pygobject3 ibus]))
wrapGAppsHook
];
}
' > ibus-typelib.nix
$ nix-shell ibus-typelib.nix --run python3
Python 3.7.3 (default, Mar 25 2019, 20:59:09)
[GCC 7.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from gi.repository import IBus
__main__:1: PyGIWarning: IBus was imported without specifying a version first. Use gi.require_version('IBus', '1.0') before import to ensure that the right version gets loaded.
>>> IBus.LookupTable(page_size=10, cursor_pos=0, cursor_visible=True, round=True)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: gobject `IBusLookupTable' doesn't support property `page_size' |
|
Looking at the tests, it should definitely work: |
|
Hmm, looks like the issue is somewhere else, the overrides from $ ls -l $(nix-build -E 'with import <nixpkgs> {}; (python3.withPackages (p: [p.pygobject3 ibus]))')/lib/python3.7/site-packages
total 44
…
lrwxrwxrwx 1 root root 101 Jan 1 1970 gi -> /nix/store/7shmlh3agdy31hhh0da2bhk9zzzpg7gp-python3.7-pygobject-3.32.1/lib/python3.7/site-packages/gi
… |
|
Now I feel stupid. We actually need to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Build gi overrides & stop building Python 2 bindings installed to Python 3 directory.
cc @laMudri
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)