Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualboxHeadless: Fix build #62393

Merged
merged 1 commit into from Jun 9, 2019
Merged

virtualboxHeadless: Fix build #62393

merged 1 commit into from Jun 9, 2019

Conversation

knedlsepp
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build virtualboxHeadless

@ofborg ofborg bot requested review from svanderburg and flokli June 1, 2019 14:13
@flokli
Copy link
Contributor

flokli commented Jun 2, 2019

@knedlsepp thanks for the PR!

I'm a bit confused however, from my understanding, the virtualbox vm tests should set virtualisation.virtualbox.headless = true;, which should cause a headless virtualbox to be used - so we should have run into this bug already.

@ambrop72, any ideas?

@knedlsepp
Copy link
Member Author

@flokli: That's kind of interesting. I was simply going through the most recent list of failed hydra builds and saw that nixpkgs:trunk:virtualboxHeadless was failing because of a missing <GL/gl.h> header.

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

Yes, the test code is confusing and perhaps test something else than intended: 78cd9f8ebc36#r33865313 but I don't think that should stop this PR.

@vcunat vcunat merged commit 25a89d0 into NixOS:master Jun 9, 2019
vcunat added a commit that referenced this pull request Jun 9, 2019
@vcunat
Merge #62393: virtualboxHeadless: Fix build
72216e1
@flokli
Copy link
Contributor

flokli commented Jun 9, 2019

@vcunat you're right - didn't want to stall this PR, just forgot about it. Thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @flokli @vcunat