Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/btsync: remove #62529

Merged
merged 3 commits into from Jun 3, 2019
Merged

nixos/btsync: remove #62529

merged 3 commits into from Jun 3, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jun 2, 2019

Motivation for this change

Remove the btsync module. Bittorrent Sync was renamed to Resilio Sync in
2016, which is supported by the resilio module. Since Resilio Sync had
some security updates since 2016, it is not safe to run Bittorrent Sync
anymore.

I will do a separate PR after this one to remove Bittorrent Sync itself (if there are no objections).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Jun 2, 2019

@danieldk 👍 for me, but I guess you can add a second commit to this PR removing the package, too.

@worldofpeace
Copy link
Contributor

I think it would be best to remove the actual package in this pr as well.
Also adding a trace to aliases.nix with a message as to why it's removed, essentially that they should use the program that now supersedes it.

Can't remember if there's something similar for nixos modules.

@davidak
Copy link
Member

davidak commented Jun 3, 2019

Maybe add a line to the release notes in the docs? So when people upgrade and still use this module, they know what to do.

@danieldk
Copy link
Contributor Author

danieldk commented Jun 3, 2019

Thanks for the suggestions! I'll incorporate them in this PR.

@danieldk
Copy link
Contributor Author

danieldk commented Jun 3, 2019

Ok, I hope all bases are covered now.

Remove the btsync module. Bittorrent Sync was renamed to Resilio Sync in
2016, which is supported by the resilio module. Since Resilio Sync had
some security updates since 2016, it is not safe to run Bittorrent Sync
anymore.
@Mic92 Mic92 merged commit e8e1dc7 into NixOS:master Jun 3, 2019
@danieldk danieldk deleted the remove-btsync-module branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants