filezilla: add wrapper to set necessary FZ_DATADIR #62340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Filezilla fails to start currently, with the following message being
shown in a lone dialog before the program exits:
This commit adds a wrapper for the filezilla binary to set the
environment variable to the package root, which fixes the issue.
This commit also sets enableParallelBuilding = true. It greatly
reduces build time, and the build isn't deterministic anyway.
(This affects master, but I would also like to request that this change be pushed to release-19.03, since Filezilla is also broken there. How can I go about doing that? Thanks.)
CC maintainer @pSub.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)/nix/store/sw1qk0z4k7lzlmv5lcc1gkmnqyzkax2z-filezilla-3.31.0 194782168
/nix/store/a3kvy3cp6ylhlhiwq4algf03h96dgh06-filezilla-3.31.0 194782688